run-container: add support for LXD VMs (SC-981)#1428
Merged
Conversation
Images of older releases (e.g. CentOS 7) can't run as containers on newer Ubuntu releases because they need a CGroupV1 host system. They can however run as VMs.
paride
commented
May 4, 2022
| local src="$1" name="$2" use_vm="$3" | ||
| debug 1 "starting container $name from '$src'" | ||
| lxc launch "$src" "$name" || { | ||
| launch_flags=() |
Contributor
Author
There was a problem hiding this comment.
This lays foundation for another change I have in mind: use ephemeral containers: when handling multiple parameters arrays as much more convenient.
paride
changed the title
aciba90
pushed a commit
to aciba90/cloud-init
that referenced
this pull request
May 10, 2022
Images of older releases (e.g. CentOS 7) can't run as containers on newer Ubuntu releases because they need a CGroupV1 host system. They can however run as VMs.
This was referenced May 12, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Commit Message
Additional Context
This change will be backported to the
stable-19.4branch, whichis used in Jenkins to test builds of 19.4 on CentOS 7.
Test Steps
This will fail to launch the container:
This will not fail to launch the container
It will however fail for other unrelated reasons.
Full test in VM mode:
Checklist: