testing: mock uses_systemd in ssh password tests (SC-1040)#1449
Merged
Conversation
Tests currently assume systemd, so add a mock such that uses_systemd always returns True.
TheRealFalcon
changed the title
blackboxsw
approved these changes
May 12, 2022
Collaborator
There was a problem hiding this comment.
Looks good and fixes the specific leak.
I'll probably provide a followup PR to refactor some of those tests to get both systemd and non_systemd environments.
UPDATE: here is an update/diff against your current PR instead of main.
TheRealFalcon/cloud-init@fix-dailies...blackboxsw:fix-dailies
- Also refactor a couple CiTestCases to pytest - use get_cloud instead of self.tmp_cloud where possible
Contributor
Author
|
@blackboxsw , thanks for this! I incorporated your changes with a couple small tweaks. Will merge assuming CI passes. |
3 tasks
aciba90
pushed a commit
to aciba90/cloud-init
that referenced
this pull request
May 13, 2022
…nical#1449) - Also refactor a couple CiTestCases to pytest - use get_cloud instead of self.tmp_cloud where possible Co-authored-by: Chad Smith <chad.smith@canonical.com>
This was referenced May 12, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Commit Message
Additional Context
Dailies are failing. See
https://launchpadlibrarian.net/600835820/buildlog_ubuntu-jammy-amd64.cloud-init_22.1-3228-g3e5938c6-0ubuntu1+1959~trunk~ubuntu22.04.1_BUILDING.txt.gz
Test Steps
I haven't actually reproduced the errors on a local machine, but based on the failures I would be surprised if the new mock doesn't work.