testing: make fake cloud-init wait actually wait#1459
Merged
Conversation
holmanb
approved these changes
May 17, 2022
Member
holmanb
left a comment
holmanb
left a comment
There was a problem hiding this comment.
One optional comment/question, otherwise looks good!
| if ( | ||
| result | ||
| and result.ok | ||
| and ("running" not in result or "not run" not in result) |
Member
There was a problem hiding this comment.
Is there a reason we need --long here?
I don't think we are checking the extra output so to avoid future false positives ("running" or "not run" in the extra details) think we should drop it?
This was referenced May 12, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Commit Message
Fixes: https://jenkins.canonical.com/server-team/view/cloud-init/job/cloud-init-integration-impish-lxd_container/21/testReport/junit/tests.integration_tests.cmd/test_status/test_wait_when_no_datasource/