net/cmdline: correctly handle static ip= config#201
Merged
Conversation
xnox
force-pushed
the
fix-static-ipconfig
branch
from
b6bf688 to
844cdbe
Compare
OddBloke
suggested changes
Jan 30, 2020
Collaborator
OddBloke
left a comment
OddBloke
left a comment
There was a problem hiding this comment.
Thanks for tracking this down! I have a couple of inline requests: one to improve our docs a little, and one because I think this fix is partially incorrect.
It is proto 'none', not 'static' as was mistakenly implemented in initramfs-tools/cloud-init in the past, yet was never the case in the klibc ipconfig state file output. LP: #1861412
xnox
force-pushed
the
fix-static-ipconfig
branch
from
844cdbe to
b78742d
Compare
OddBloke
approved these changes
Jan 30, 2020
Collaborator
OddBloke
left a comment
OddBloke
left a comment
There was a problem hiding this comment.
This LGTM now, thank you!
Collaborator
|
Oracle is the one cloud platform I'm aware of that uses initramfs networking, and they use the "dhcp" protocol, so we shouldn't see any change in behaviour there. |
Merged
This was referenced May 11, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is proto 'none', not 'static' as was mistakenly implemented in
initramfs-tools/cloud-init in the past, yet was never the case in the
klibc ipconfig state file output.
LP: #1861412