Skip to content

net: Document use of ip route append to add routes #2130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TheRealFalcon merged 3 commits into from
Apr 21, 2023
+8 −0
Merged

net: Document use of ip route append to add routes #2130

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9d9b85f
net: Use `ip route add` to add static routes
holmanb Apr 19, 2023
f71dfc4
Revert "net: Use `ip route add` to add static routes"
holmanb Apr 20, 2023
8668534
add comment explaining the requirement for 'ip r add'
holmanb Apr 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions cloudinit/net/ephemeral.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,6 +197,14 @@ def _bringup_static_routes(self):
via_arg = []
if gateway != "0.0.0.0":
via_arg = ["via", gateway]

# Use "append" rather than "add" since the DHCP server may provide
# rfc3442 classless static routes with multiple routes to the same
# subnet via different routers or local interface addresses.
#
# In this scenario, `ip r add` fails.
#
# RHBZ: #2003231
subp.subp(
["ip", "-4", "route", "append", net_address]
+ via_arg
Expand Down