Ephemeral Networking for FreeBSD

[igalic]

Proposed Commit Message

implement ephemeral networking for BSD

After #2127 lay the foundation, we now implement the BSD side of this

Sponsored by: The FreeBSD Foundation

Additional Context

This is based on #2127

Test Steps

I have tested this successfully on libvirt with NoCloud (standard dhcp), on Hetzner (EphemeralDHCPv4) and with config-drive with a static network setup (regards to @goneri )

Checklist:

• My code follows the process laid out in the documentation
• I have updated or added any unit tests accordingly
• I have updated or added any documentation accordingly

[cjp256]

is this intended to be configurable? defined as class variable and instance variable

[igalic]

that's a question for @holmanb

[holmanb]

is this intended to be configurable? defined as class variable and instance variable

This is not intended to be configurable at runtime. This is defined as an instance variable to avoid unpickle issues across the upgrade path. It might not be required as a class variable, I don't recall why it is defined both ways.

[cjp256]

just a personal preference, but for readability, I think I'd rather see the args built up over a few lines and conditionals than trying to get it all into one statement. e.g.

args = [
            path,
            "-1",
            "-v",
            "-lf",
            lease_file,
            "-pf",
            pid_file,
            "-sf",
            "/bin/true",
        ]

if config_file:
    args.extend(["-cf", config_file, interface])

args.append(interface)

I may be alone in this preference, so feel free to ignore :D

[igalic]

i like the idea!
but this, too is @holmanb's code.

[holmanb]

I'm fine with that.

[igalic]

guide posts for reviewers

[igalic]

We don't support source selection

and i had to make this addition in two steps, because when i did it in a single step, the result was nonsense.

[github-actions]

Hello! Thank you for this proposed change to cloud-init. This pull request is now marked as stale as it has not seen any activity in 14 days. If no activity occurs within the next 7 days, this pull request will automatically close.

If you are waiting for code review and you are seeing this message, apologies! Please reply, tagging TheRealFalcon, and he will ensure that someone takes a look soon.

(If the pull request is closed and you would like to continue working on it, please do tag TheRealFalcon to reopen it.)

[holmanb]

Looks good to me. Thanks!