rbxcloud: gracefully handle arping errors#262
Merged
Conversation
Collaborator
|
Hey @ad-m, as this has a CI failure I'm holding off on reviewing it for now. Please do let me know if you need assistance fixing the CI failure! |
Contributor
Author
|
@OddBloke, fixed. Could you take a look? |
OddBloke
suggested changes
Mar 31, 2020
Collaborator
OddBloke
left a comment
OddBloke
left a comment
There was a problem hiding this comment.
The code change itself looks good, but I'd like to see us update the existing tests to cover this new behaviour. Thanks!
This was referenced May 12, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am co-worker of RbxCloud provider.
We have noticed that in the case of a specific network configuration, the current arping execution for IP addresses ended with .1, .2 and .3 fails, as it is not supported. In future network hardware of platform, .2 and .3 IP addresses will probably not be required and not supported at all.
Currently, no arping to all IP address does not mean no network communication, but degraded service until ARP lease. For this reason, this error should not stop the datasource, but only be logged in.
This behavior also allows us to gracefully discontinue use of .2 and .3 IP addresses in all future network configurations. It also means that the message should be logged in instead of stopping datasource completely.