Test acceptance of x-shellscript as cloud-config.#290
Merged
raharper merged 5 commits intoMar 31, 2020
Conversation
Test case from Ryan Harper in discussion of PR#234 (canonical#234). This should demonstrate that cloud-init (without the subsequent patches) will fail to accept multipart user-data documents with the cloud-config piece (mis)declared as text/x-shellscript. This happens on old heat on OpenTelekomCloud. Let's watch this fail the CI and then add the fix ... Signed-off-by: Kurt Garloff <kurt@garloff.de>
This patch if from Ryan Harper (inspired by my bug report and a suggestion from Scott Moser) from the discussion on PR canonical#234. cloud-init would not accept unexpected mime-types in multipart user-data for the cloud-config piece before; now it does. Problem was observed and reproduced with old heat on OTC and is now fixed. Signed-off-by: Kurt Garloff <kurt@garloff.de>
Contributor
Author
|
This is ready for review now. |
raharper
approved these changes
Mar 31, 2020
Contributor
Author
|
Thanks, Ryan! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don't pull just yet -- this is the testcase first, adding the fix as second step (TDD).
So this will fail the CI and the subsequent patch should fix it ...
Test case from Ryan Harper in discussion of PR#234
(#234).
This should demonstrate that cloud-init (without the subsequent
patches) will fail to accept multipart user-data documents
with the cloud-config piece (mis)declared as text/x-shellscript.
This happens on old heat on OpenTelekomCloud.
Let's watch this fail the CI and then add the fix ...
Signed-off-by: Kurt Garloff kurt@garloff.de