Add support for NFS/EFS mounts#300
Merged
Merged
Conversation
OddBloke
reviewed
Apr 2, 2020
OddBloke
reviewed
Apr 2, 2020
Collaborator
OddBloke
left a comment
OddBloke
left a comment
There was a problem hiding this comment.
Thanks for the submission! Broadly speaking, this looks good to me. I have one (minor) inline comment, and I've asked @raharper to review that the regex isn't going to match any of the esoteric device names he might be familiar with.
Co-Authored-By: Daniel Watkins <daniel@daniel-watkins.co.uk>
OddBloke
reviewed
Apr 2, 2020
Co-Authored-By: Daniel Watkins <daniel@daniel-watkins.co.uk>
This was referenced May 12, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The cc_mounts module does not support NFS mounts in the form of
hostname:/orhostname:/path.This PR adds support for NFS-style paths in the fs_spec field.
LP: #1870370