analyze/dump: add support for Amazon Linux 2 log lines#346
Merged
Conversation
Collaborator
Author
|
These tests are failing because the expected and actual time are exactly 4 hours apart (i.e. the time difference from my system to UTC), so I need to figure out (a) why that isn't happening in other tests, and (b) how to address it. |
Amazon Linux 2 is configured with a log format different to the one shipped by upstream, which means analyze fails to parse any of the log lines. This updates the code to know how to parse such lines. LP: #1876323
Collaborator
Author
|
OK, sorted out the tests, and Travis is looking good, so ready for review again. |
raharper
approved these changes
May 6, 2020
Collaborator
raharper
left a comment
raharper
left a comment
There was a problem hiding this comment.
This looks fine. Just one question, should we name and variablize the different separators?
| # init-local/check-cache: attempting to read from cache [check] | ||
|
|
||
| separators = [' - ', ' [CLOUDINIT] '] | ||
| separators = [' - ', ' [CLOUDINIT] ', ' cloud-init['] |
Collaborator
There was a problem hiding this comment.
Do you think it's worth naming these separators ?
SEP1 = ' - '
SEP2 = ' [CLOUDINIT] ',
SEP3 = ' cloud-init['
separators = [SEP1, SEP2, SEP3]
and then the if sep == SEP3
Collaborator
Author
There was a problem hiding this comment.
Yep, good thinking, I'll submit that as a follow-up.
OddBloke
added a commit
to OddBloke/cloud-init
that referenced
this pull request
May 6, 2020
This was a minor cleanup suggested by Ryan in canonical#346.
This was referenced May 12, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Amazon Linux 2 is configured with a log format different to the one
shipped by upstream, which means analyze fails to parse any of the log
lines. This updates the code to know how to parse such lines.
LP: #1876323