templater: drop Jinja Python 2 compatibility shim#353
Merged
Conversation
lucasmoura
approved these changes
May 11, 2020
Contributor
lucasmoura
left a comment
lucasmoura
left a comment
There was a problem hiding this comment.
For what I could understand, this is because in python2 the character representation is done through __unicode__ snd this decorator just create an abstraction to allow __str__ to also return unicode strings.
If that is the case, I can see no problems with the proposed change
TheRealFalcon
approved these changes
May 11, 2020
blackboxsw
approved these changes
May 15, 2020
Collaborator
blackboxsw
left a comment
blackboxsw
left a comment
There was a problem hiding this comment.
Just tested jinja template variable render failures with this branch and missing vars are properly rendered in error messages. LGTM!
.tox/py3/bin/python3 -m cloudinit.cmd.main query -f '{{absent}}' -i instance-data.json
WARNING: Could not render jinja template variables in file 'query commandline': 'absent'
CI_MISSING_JINJA_VAR/absent
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.