cc_snap: apply validation to snap.commands properties#364
Merged
Conversation
Collaborator
Author
|
I think this is ready for review as-is. @blackboxsw identified a bug in our annotation code when testing this last week, but that bug is not introduced by this PR. (I'll file that bug in a minute.) |
Collaborator
Author
blackboxsw
approved these changes
May 18, 2020
Collaborator
blackboxsw
left a comment
blackboxsw
left a comment
There was a problem hiding this comment.
When I resolved my own invalid YAML issues this looks like it works great
This was referenced May 12, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Specifically, ensure that given values are either strings, or arrays of strings.