Enhance poll imds logging#365
Merged
blackboxsw merged 15 commits intoJun 3, 2020
Merged
Conversation
…ustafa/cloud-init into enhancePollImdsLogging
blackboxsw
requested changes
May 18, 2020
Collaborator
blackboxsw
left a comment
blackboxsw
left a comment
There was a problem hiding this comment.
Thanks for this branch, functionally it looks pretty good. Just wondering we can get a little unit test coverage for the new functionality.
blackboxsw
reviewed
May 23, 2020
blackboxsw
approved these changes
May 26, 2020
Collaborator
blackboxsw
left a comment
blackboxsw
left a comment
There was a problem hiding this comment.
+1 thanks for getting some test coverage down the new error code route.
added 2 commits
May 26, 2020 23:37
…ustafa/cloud-init into enhancePollImdsLogging Merging upstream changes
blackboxsw
approved these changes
Jun 3, 2020
Collaborator
blackboxsw
left a comment
blackboxsw
left a comment
There was a problem hiding this comment.
Thank you for the updates here @Moustafa-Moustafa
Merged
This was referenced May 10, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improving the debugability of this code path by logging the thrown exception details for the non 404 exceptions.