conftest: implement partial disable_subp_usage#371
Merged
Conversation
This allows tests to be configured to permit some commands to be run via util.subp, while still rejecting any unexpected calls. See the documentation for further details.
Collaborator
Author
|
I have a concrete case for this locally which I have tested with. This change stands on its own, however, so I'm proposing it separately. |
blackboxsw
reviewed
May 19, 2020
blackboxsw
approved these changes
May 19, 2020
Collaborator
blackboxsw
left a comment
blackboxsw
left a comment
There was a problem hiding this comment.
Looks good, one tiny request on the test and it can land.
TheRealFalcon
approved these changes
May 20, 2020
Co-authored-by: Chad Smith <chad.smith@canonical.com>
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows tests to be configured to permit some commands to be run via
util.subp, while still rejecting any unexpected calls. See the
documentation for further details.