Ubuntu/xenial add quilt patches to disable SRU_BLOCKERS#406
Merged
Conversation
Instead of running pycodestyle and pyflakes seperately, use flake8 to get the benefits of pyflakes and also stylistic checks as well as the ability to configure the settings for the project.
Co-authored-by: Daniel Watkins <oddbloke@ubuntu.com>
This removes the use of variables named ‘l’, ‘O’, or ‘I’. Generally these are used in list comprehension to read the line of lines.
…anonical#358) Replace the hardcoded list of devices with a more robust way of determining the device which grub is installed to. We use grub-probe to fetch the underlying disk the /boot directory is located on, and attempt to match the disk with its /dev/disk/by-id value. If no such /dev/disk/by-id/ value exists, we fallback to the plain disk name. The changes are robust to unstable kernel device names and ordering, and use /dev/disk/by-id values to populate grub-pc/install_devices where possible. LP: #1877491
This puts an ignore on the imports not at the top of the file errors. The reason for the ignore instead of fix is that the file is using imp to grab a lock and patch logging before further imports are completed.
Remove extra spaces after a ','
blackboxsw
force-pushed
the
ubuntu/xenial
branch
2 times, most recently
from
69a80f6 to
936088f
Compare
lucasmoura
reviewed
Jun 3, 2020
Contributor
lucasmoura
left a comment
lucasmoura
left a comment
There was a problem hiding this comment.
We should edit the ec2-classic-dont-reapply-networking.patch to remove the following import:
from cloudinit.event import EventType
Otherwise we get the following flake8 warning:
cloudinit/sources/DataSourceEc2.py:22:1: F401 'cloudinit.event.EventType' imported but unused
Collaborator
Author
Thanks for this, I fixed by editing that patch directly: |
lucasmoura
approved these changes
Jun 4, 2020
lucasmoura
approved these changes
Jun 4, 2020
Contributor
lucasmoura
left a comment
lucasmoura
left a comment
There was a problem hiding this comment.
I was able to reproduce the steps and build the packages.
But the package build reported the following lintian errors:
W: cloud-init source: binary-nmu-debian-revision-in-source 20.2-45-g5f7825e2-0ubuntu1~16.04.1
E: cloud-init source: untranslatable-debconf-templates cloud-init.templates: 6
W: cloud-init source: missing-file-from-potfiles-in grub.templates
W: cloud-init source: out-of-date-standards-version 3.9.6 (current is 3.9.7)
W: cloud-init: binary-without-manpage usr/bin/cloud-id
W: cloud-init: binary-without-manpage usr/bin/cloud-init
W: cloud-init: binary-without-manpage usr/bin/cloud-init-per
W: cloud-init: command-with-path-in-maintainer-script postinst:141 /usr/sbin/grub-install
W: grub-legacy-ec2: binary-without-manpage usr/sbin/grub-set-default
W: grub-legacy-ec2: binary-without-manpage usr/sbin/grub-set-default-legacy-ec2
W: grub-legacy-ec2: binary-without-manpage usr/sbin/update-grub-legacy-ec2
W: ec2-init: empty-binary-package
Collaborator
Author
+1 thanks @lucasmoura we will track these lintian issues for our next SRU. the translatable templates have been fixed in ubuntu/focal && devel already by paride I believe. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add two quilt patches by following the ubuntu release quilt patch procedure.
Here are some manual steps to produce this;
quilt push -a
tox -p auto
quilt pop -a
build-package
sbuild-it ../out/cloud-init_20.2-45-g5f7825e2-0ubuntu1~16.04.1.dsc