test: move conftest.py to top-level, to cover tests/ also#414
Merged
Conversation
Contributor
|
Mhh, how is it that Travis CI didn't run on this PR? |
paride
approved these changes
Jun 8, 2020
Contributor
|
LGTM, but you'll have to merge :) |
TheRealFalcon
approved these changes
Jun 8, 2020
And allow it to run bash. (We aren't aiming to convert TestCase tests to pytest tests as a rule. In this case, I needed to change its implementation to limit subp usage, and I chose pytest over CiTestCase.)
This gives us a single conftest.py which is shared by all tests in the project.
Merged
This was referenced May 10, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This gives us a single conftest.py which is shared by all tests in the project.
(Also fix the one
tests/test which started failing due to subp usage.)