Fixes KeyError for bridge with no "parameters:" setting#423
Conversation
|
Note: commit ded1ec8 did include a test case, but didn't test the case where no "parameters:" were provided. I don't have an environment set up to be able to run the test suite for cloud-init, but someone might want to add the missing test case. |
|
CLA now signed |
|
Thank you so much, rerunning the travis checks. |
TheRealFalcon
left a comment
TheRealFalcon
left a comment
There was a problem hiding this comment.
Thank you for your contribution and for signing the CLA!
One final step in signing the CLA is to add your name (alphabetically please!) to the CLA signers file located at tools/.github-cla-signers . It can be added in this PR.
Yes, it is a good idea to add an additional test case for this fix, but a local environment is not necessary for unit testing. Tests will be run when you push a new commit on this PR. If you use the test you linked to in ded1ec8 , it should be possible to create a new test using the same format.
candlerb
force-pushed
the
bridge-parameters
branch
2 times, most recently
from
aa0ec2f to
407247b
Compare
candlerb
force-pushed
the
bridge-parameters
branch
from
407247b to
0f36b3a
Compare
TheRealFalcon
left a comment
TheRealFalcon
left a comment
There was a problem hiding this comment.
Looks good, thanks! We should be able to get this committed soon.
blackboxsw
left a comment
blackboxsw
left a comment
There was a problem hiding this comment.
+1 and validated that CLA is signed.
4 participants
LP #1879673
Reason: commit ded1ec8 introduced a regression whereby a bridge with no "parameters:" setting caused a KeyError exception.