analyze: fix (unexpected) timestamp parsing#4347
Merged
holmanb merged 1 commit intoAug 16, 2023
Merged
Conversation
igalic
force-pushed
the
fix/gnu-date-timestamp-parsing-tests
branch
2 times, most recently
from
f7ce6ba to
e9180dc
Compare
In case of very unexpected timestamps, we pass them on to date. Unfortunately, only GNU date is able to perform this level of deduction (guess work). Rework the code and tests to look for GNU date on non-Linux platforms. Only fail, by throwing an Exception! if GNU date cannot be found. add `timestampstr` to that exception, so we know why we're in this code path to begin with. Sponsored by: The FreeBSD Foundation This patch (partially) Fixes: canonicalGH-4333 Co-authored-by: Brett Holman <brett.holman@canonical.com>
igalic
commented
Aug 16, 2023
holmanb
reviewed
Aug 16, 2023
Member
holmanb
left a comment
holmanb
left a comment
There was a problem hiding this comment.
Aside from "making it just work" (which this PR does), I'm tempted to say that maybe it would be better if at some point in the future we didn't depend on GNU date and transitionally logged a warning anytime parse_timestamp_from_date() is called so that we can collect logs for any formats that could be handled in python code directly. I didn't see this path actually taken on Ubuntu, so I'm curious when (if) this path actually gets taken.
Thoughts?
Collaborator
Author
|
I've only seen this in tests. |
Member
I'll make it a separate bug. |
igalic
force-pushed
the
fix/gnu-date-timestamp-parsing-tests
branch
from
fcfaa60 to
72b78e2
Compare
holmanb
approved these changes
Aug 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Commit Message
Additional Context
Test Steps
Checklist: