util: add ensure_dir_exists parameter to write_file#443
Merged
Conversation
This allows us to disable the `ensure_dir` call when it isn't appropriate.
smoser
reviewed
Jun 19, 2020
Collaborator
smoser
left a comment
There was a problem hiding this comment.
ensure_dir_exists -> mkdirs ?
2 things
- shorter
- plural - ensure_dir will create all parent directories on the way.
cons:
- isn't named 'ensure_dir' which lines up with the cloud-init function.
i'm fine with either.
Collaborator
Author
|
Thanks for taking a look! I think I prefer |
Merged
This was referenced May 10, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows us to disable the
ensure_dircall when it isn'tappropriate.