Update build-on-openbsd dependencies#4644
Merged
Merged
Conversation
Collaborator
|
that failing test links to https://cloudinit.readthedocs.io/en/latest/development/first_PR.html and it's asking you to sign the CLA |
* script would fail will needing to do work with python netifaces
module.
* linting: SC2806 - Double quote to prevent globbing and word
splitting.
* Added myself as contributor
Member
|
Hey @CodeBleu, thanks for jumping on this! There is actually an effort to drop this dependency at the moment, so this change might not stick around for too long, but until that lands, this fixes the issue you hit. Thanks for the contribution and welcome to cloud-init! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: Update build-on-openbsd dependencies