Skip to content

Update build-on-openbsd dependencies#4644

Merged
holmanb merged 1 commit into
canonical:mainfrom
American-Cloud:main
Nov 30, 2023
Merged

Update build-on-openbsd dependencies#4644
holmanb merged 1 commit into
canonical:mainfrom
American-Cloud:main

Conversation

@CodeBleu
Copy link
Copy Markdown
Contributor

fix: Update build-on-openbsd dependencies

* script would fail will needing to do work with python netifaces
  module.
* linting: SC2806 -  Double quote to prevent globbing and word
  splitting.

@igalic
Copy link
Copy Markdown
Collaborator

igalic commented Nov 30, 2023

that failing test links to https://cloudinit.readthedocs.io/en/latest/development/first_PR.html and it's asking you to sign the CLA

    * script would fail will needing to do work with python netifaces
      module.
    * linting: SC2806 -  Double quote to prevent globbing and word
      splitting.
    * Added myself as contributor
Copy link
Copy Markdown
Collaborator

@igalic igalic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@holmanb
Copy link
Copy Markdown
Member

holmanb commented Nov 30, 2023

Hey @CodeBleu, thanks for jumping on this!

There is actually an effort to drop this dependency at the moment, so this change might not stick around for too long, but until that lands, this fixes the issue you hit.

Thanks for the contribution and welcome to cloud-init!

Copy link
Copy Markdown
Member

@holmanb holmanb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@holmanb holmanb merged commit 191b5fe into canonical:main Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants