cloudinit: fix tip-pylint failures and bump pinned pylint version#478
Merged
Conversation
Contributor
|
Glad that my email brought to some actual improvements, even if my conclusion on the errors being false positive was wrong :) Just a question: why bumping pylint to 2.4.2 and not to the latest version (2.5.3)? |
Collaborator
Author
One of them was, and the other is pretty subtle!
Haha, because the latest version of astroid is 2.4.2 and I misremembered that as the latest pylint version. Let me fix that! |
Specifically: * disable E1102 in cloudinit/sources/helpers/openstack.py for reasons described in a comment, and * refactor `abs_join` to require at least one positional argument; this matches os.path.join's signature, and that mismatch is what was causing pylint to emit a warning * bump to pylint 2.4.2
Collaborator
Author
Done. |
paride
approved these changes
Jul 6, 2020
TheRealFalcon
approved these changes
Jul 6, 2020
blackboxsw
approved these changes
Jul 6, 2020
Merged
This was referenced May 10, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Specifically:
cloudinit/sources/helpers/openstack.pyfor reasonsdescribed in a comment, and
util.abs_jointo require at least one positional argument; thismatches
os.path.join's signature, and that mismatch is what wascausing pylint to emit a warning