Skip to content

LXD cloud_tests: support more lxd image formats#482

Merged
raharper merged 4 commits into
canonical:masterfrom
paride:new-lxd-image-export-format
Jul 9, 2020
Merged

LXD cloud_tests: support more lxd image formats#482
raharper merged 4 commits into
canonical:masterfrom
paride:new-lxd-image-export-format

Conversation

@paride
Copy link
Copy Markdown
Contributor

@paride paride commented Jul 7, 2020

LP: #1886080

Copy link
Copy Markdown
Collaborator

@raharper raharper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should follow up with LXD folks on all of the different export formats we might encounter. I think typically the images we use come in one or two, but there may be more for future images we want to test with.

Comment thread tests/cloud_tests/platforms/lxd/image.py
Comment thread tests/cloud_tests/platforms/lxd/image.py
@paride
Copy link
Copy Markdown
Contributor Author

paride commented Jul 8, 2020

The latest revision I pushed should support any image format provided that it's split.

Comment thread tests/cloud_tests/platforms/lxd/image.py Outdated
Copy link
Copy Markdown
Collaborator

@raharper raharper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

@paride paride force-pushed the new-lxd-image-export-format branch from f274045 to 998aa0f Compare July 9, 2020 08:46
@paride paride changed the title Adapt the LXD tests to the new lxd image export format LXD cloud_tests: support more lxd image formats Jul 9, 2020
@paride
Copy link
Copy Markdown
Contributor Author

paride commented Jul 9, 2020

I retitled the PR as it's really about supporting more formats rather than supporting a new format.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants