Skip to content

tests: pro integration tests supply ubuntu_advantage until pro v32#4935

Merged
TheRealFalcon merged 1 commit into
canonical:mainfrom
blackboxsw:tests-integration-test-use-ubuntu-advantage-until-pro-v32
Feb 21, 2024
Merged

tests: pro integration tests supply ubuntu_advantage until pro v32#4935
TheRealFalcon merged 1 commit into
canonical:mainfrom
blackboxsw:tests-integration-test-use-ubuntu-advantage-until-pro-v32

Conversation

@blackboxsw
Copy link
Copy Markdown
Collaborator

Until ubuntu-advantage-tools version 32 is SRU'd to stable series Pro images will continue to auto-attach by default unless an ubuntu_advantage key is provided in user-data.

Allow our integration test to provide ubuntu_advantage and ubuntu_pro keys knowing that any ubuntu_pro config overrides ubuntu_advantage in latest cloud-init.

This will emit a warning message about preference of ubuntu_pro over ubuntu_advantage and deprecation warnings, but the integration test doesn't validate deprecation warnings.

We can drop ubuntu_advantage from our user-data in May when Pro 32 releases.

Proposed Commit Message

<type>(optional scope): <summary>  # no more than 72 characters

A description of what the change being made is and why it is being
made if the summary line is insufficient.  This should be wrapped at
72 characters.

If you need to write multiple paragraphs, feel free.

Fixes GH-NNNNN (GitHub Issue number. Remove line if irrelevant)
LP: #NNNNNN (Launchpad bug number. Remove line if irrelevant)

Additional Context

Test Steps

Checklist

Merge type

  • Squash merge using "Proposed Commit Message"
  • Rebase and merge unique commits. Requires commit messages per-commit each referencing the pull request number (#<PR_NUM>)

Until ubuntu-advantage-tools version 32 is SRU'd to stable series
Pro images will continue to auto-attach by default unless an
ubuntu_advantage key is provided in user-data.

Allow our integration test to provide ubuntu_advantage and ubuntu_pro
keys knowing that any ubuntu_pro config overrides ubuntu_advantage
in latest cloud-init.

This will emit a warning message about preference of ubuntu_pro
over ubuntu_advantage and deprecation warnings, but the integration
test doesn't validate deprecation warnings.

We can drop ubuntu_advantage from our user-data in May when Pro 32
releases.
Copy link
Copy Markdown
Contributor

@TheRealFalcon TheRealFalcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@TheRealFalcon TheRealFalcon merged commit 6f52f15 into canonical:main Feb 21, 2024
blackboxsw added a commit that referenced this pull request Feb 27, 2024
…4935)

Until ubuntu-advantage-tools version 32 is SRU'd to stable series
Pro images will continue to auto-attach by default unless an
ubuntu_advantage key is provided in user-data.

Allow our integration test to provide ubuntu_advantage and ubuntu_pro
keys knowing that any ubuntu_pro config overrides ubuntu_advantage
in latest cloud-init.

This will emit a warning message about preference of ubuntu_pro
over ubuntu_advantage and deprecation warnings, but the integration
test doesn't validate deprecation warnings.

We can drop ubuntu_advantage from our user-data in May when Pro 32
releases.
blackboxsw added a commit that referenced this pull request Feb 27, 2024
…4935)

Until ubuntu-advantage-tools version 32 is SRU'd to stable series
Pro images will continue to auto-attach by default unless an
ubuntu_advantage key is provided in user-data.

Allow our integration test to provide ubuntu_advantage and ubuntu_pro
keys knowing that any ubuntu_pro config overrides ubuntu_advantage
in latest cloud-init.

This will emit a warning message about preference of ubuntu_pro
over ubuntu_advantage and deprecation warnings, but the integration
test doesn't validate deprecation warnings.

We can drop ubuntu_advantage from our user-data in May when Pro 32
releases.
blackboxsw added a commit that referenced this pull request Feb 27, 2024
…4935)

Until ubuntu-advantage-tools version 32 is SRU'd to stable series
Pro images will continue to auto-attach by default unless an
ubuntu_advantage key is provided in user-data.

Allow our integration test to provide ubuntu_advantage and ubuntu_pro
keys knowing that any ubuntu_pro config overrides ubuntu_advantage
in latest cloud-init.

This will emit a warning message about preference of ubuntu_pro
over ubuntu_advantage and deprecation warnings, but the integration
test doesn't validate deprecation warnings.

We can drop ubuntu_advantage from our user-data in May when Pro 32
releases.
holmanb pushed a commit to holmanb/cloud-init that referenced this pull request Mar 5, 2024
…anonical#4935)

Until ubuntu-advantage-tools version 32 is SRU'd to stable series
Pro images will continue to auto-attach by default unless an
ubuntu_advantage key is provided in user-data.

Allow our integration test to provide ubuntu_advantage and ubuntu_pro
keys knowing that any ubuntu_pro config overrides ubuntu_advantage
in latest cloud-init.

This will emit a warning message about preference of ubuntu_pro
over ubuntu_advantage and deprecation warnings, but the integration
test doesn't validate deprecation warnings.

We can drop ubuntu_advantage from our user-data in May when Pro 32
releases.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants