tests: pro integration tests supply ubuntu_advantage until pro v32#4935
Merged
TheRealFalcon merged 1 commit intoFeb 21, 2024
Conversation
Until ubuntu-advantage-tools version 32 is SRU'd to stable series Pro images will continue to auto-attach by default unless an ubuntu_advantage key is provided in user-data. Allow our integration test to provide ubuntu_advantage and ubuntu_pro keys knowing that any ubuntu_pro config overrides ubuntu_advantage in latest cloud-init. This will emit a warning message about preference of ubuntu_pro over ubuntu_advantage and deprecation warnings, but the integration test doesn't validate deprecation warnings. We can drop ubuntu_advantage from our user-data in May when Pro 32 releases.
blackboxsw
added a commit
that referenced
this pull request
Feb 27, 2024
…4935) Until ubuntu-advantage-tools version 32 is SRU'd to stable series Pro images will continue to auto-attach by default unless an ubuntu_advantage key is provided in user-data. Allow our integration test to provide ubuntu_advantage and ubuntu_pro keys knowing that any ubuntu_pro config overrides ubuntu_advantage in latest cloud-init. This will emit a warning message about preference of ubuntu_pro over ubuntu_advantage and deprecation warnings, but the integration test doesn't validate deprecation warnings. We can drop ubuntu_advantage from our user-data in May when Pro 32 releases.
blackboxsw
added a commit
that referenced
this pull request
Feb 27, 2024
…4935) Until ubuntu-advantage-tools version 32 is SRU'd to stable series Pro images will continue to auto-attach by default unless an ubuntu_advantage key is provided in user-data. Allow our integration test to provide ubuntu_advantage and ubuntu_pro keys knowing that any ubuntu_pro config overrides ubuntu_advantage in latest cloud-init. This will emit a warning message about preference of ubuntu_pro over ubuntu_advantage and deprecation warnings, but the integration test doesn't validate deprecation warnings. We can drop ubuntu_advantage from our user-data in May when Pro 32 releases.
blackboxsw
added a commit
that referenced
this pull request
Feb 27, 2024
…4935) Until ubuntu-advantage-tools version 32 is SRU'd to stable series Pro images will continue to auto-attach by default unless an ubuntu_advantage key is provided in user-data. Allow our integration test to provide ubuntu_advantage and ubuntu_pro keys knowing that any ubuntu_pro config overrides ubuntu_advantage in latest cloud-init. This will emit a warning message about preference of ubuntu_pro over ubuntu_advantage and deprecation warnings, but the integration test doesn't validate deprecation warnings. We can drop ubuntu_advantage from our user-data in May when Pro 32 releases.
holmanb
pushed a commit
to holmanb/cloud-init
that referenced
this pull request
Mar 5, 2024
…anonical#4935) Until ubuntu-advantage-tools version 32 is SRU'd to stable series Pro images will continue to auto-attach by default unless an ubuntu_advantage key is provided in user-data. Allow our integration test to provide ubuntu_advantage and ubuntu_pro keys knowing that any ubuntu_pro config overrides ubuntu_advantage in latest cloud-init. This will emit a warning message about preference of ubuntu_pro over ubuntu_advantage and deprecation warnings, but the integration test doesn't validate deprecation warnings. We can drop ubuntu_advantage from our user-data in May when Pro 32 releases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Until ubuntu-advantage-tools version 32 is SRU'd to stable series Pro images will continue to auto-attach by default unless an ubuntu_advantage key is provided in user-data.
Allow our integration test to provide ubuntu_advantage and ubuntu_pro keys knowing that any ubuntu_pro config overrides ubuntu_advantage in latest cloud-init.
This will emit a warning message about preference of ubuntu_pro over ubuntu_advantage and deprecation warnings, but the integration test doesn't validate deprecation warnings.
We can drop ubuntu_advantage from our user-data in May when Pro 32 releases.
Proposed Commit Message
Additional Context
Test Steps
Checklist
Merge type