Skip to content

chore(ephemeral): add debug log when bringing up ephemeral network#5010

Merged
holmanb merged 2 commits into
canonical:mainfrom
a-dubs:add-debug-log-for-ephemeral-network
Mar 6, 2024
Merged

chore(ephemeral): add debug log when bringing up ephemeral network#5010
holmanb merged 2 commits into
canonical:mainfrom
a-dubs:add-debug-log-for-ephemeral-network

Conversation

@a-dubs
Copy link
Copy Markdown
Contributor

@a-dubs a-dubs commented Mar 5, 2024

Proposed Commit Message

chore(ephemeral): add debug log when bringing up ephemeral network

A debug message is logged whenever an instance is able to connect 
to the IMDS but when it can't, and an ephemeral network needs 
brought up, nothing is logged. Adding a log message here will help 
improve readability of logs and help troubleshoot failure paths 
when an instance is having issues with networking. 

Checklist

Merge type

  • Squash merge using "Proposed Commit Message"
  • Rebase and merge unique commits. Requires commit messages per-commit each referencing the pull request number (#<PR_NUM>)

Comment thread cloudinit/net/ephemeral.py Outdated

else:
LOG.debug(
"Instance does not have connectivity to %s. Bringing up ",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to remove the trailing comma here, but otherwise LGTM!

Copy link
Copy Markdown
Member

@holmanb holmanb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@holmanb holmanb merged commit d86f35a into canonical:main Mar 6, 2024
catmsred pushed a commit to catmsred/cloud-init that referenced this pull request Mar 11, 2024
…anonical#5010)

A debug message is logged whenever an instance is able to connect 
to the IMDS but when it can't, and an ephemeral network needs 
brought up, nothing is logged. Adding a log message here will help 
improve readability of logs and help troubleshoot failure paths 
when an instance is having issues with networking.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants