Skip to content

Run container from commitish#5015

Merged
holmanb merged 1 commit into
canonical:mainfrom
holmanb:holmanb/run-container-from-commitish
Mar 6, 2024
Merged

Run container from commitish#5015
holmanb merged 1 commit into
canonical:mainfrom
holmanb:holmanb/run-container-from-commitish

Conversation

@holmanb
Copy link
Copy Markdown
Member

@holmanb holmanb commented Mar 6, 2024

Proposed Commit Message

feat(run-container): Run from arbitrary commitish

Additional Context

Assuming HEAD is a reasonable default. If one wants to run using an alternate lxc binary from a commit-ish that did not yet support doing that, for example, this would be useful.

Test Steps

./tools/run-container --commitish 24.1 --source-package --unittest --artifacts=./srpm/ rockylinux/8

Merge type

  • Squash merge using "Proposed Commit Message"
  • Rebase and merge unique commits. Requires commit messages per-commit each referencing the pull request number (#<PR_NUM>)

Copy link
Copy Markdown
Contributor

@TheRealFalcon TheRealFalcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@holmanb holmanb merged commit b7d442f into canonical:main Mar 6, 2024
catmsred pushed a commit to catmsred/cloud-init that referenced this pull request Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants