Skip to content

Parametrize devlist tests #523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
OddBloke merged 1 commit into from
Aug 7, 2020
Merged

Parametrize devlist tests #523

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
56 changes: 24 additions & 32 deletions tests/unittests/test_util.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
import shutil
import stat
import tempfile
import pytest
import yaml
from unittest import mock

Expand Down Expand Up @@ -1002,8 +1003,16 @@ def test_find_devs_with_openbsd_with_criteria(self, m_subp):
devlist = util.find_devs_with_openbsd(criteria="LABEL_FATBOOT=A_LABEL")
assert devlist == ['/dev/cd0a', '/dev/sd1i']

@pytest.mark.parametrize(
'criteria,expected_devlist', (
(None, ['/dev/msdosfs/EFISYS', '/dev/iso9660/config-2']),
('TYPE=iso9660', ['/dev/iso9660/config-2']),
('TYPE=vfat', ['/dev/msdosfs/EFISYS']),
('LABEL_FATBOOT=A_LABEL', []), # lp: #1841466
),
)
@mock.patch('glob.glob')
def test_find_devs_with_freebsd(self, m_glob):
def test_find_devs_with_freebsd(self, m_glob, criteria, expected_devlist):
def fake_glob(pattern):
msdos = ["/dev/msdosfs/EFISYS"]
iso9660 = ["/dev/iso9660/config-2"]
Expand All @@ -1014,22 +1023,20 @@ def fake_glob(pattern):
raise Exception
m_glob.side_effect = fake_glob

devlist = util.find_devs_with_freebsd()
assert set(devlist) == set([
'/dev/iso9660/config-2', '/dev/msdosfs/EFISYS'])

devlist = util.find_devs_with_freebsd(criteria="TYPE=iso9660")
assert devlist == ['/dev/iso9660/config-2']

devlist = util.find_devs_with_freebsd(criteria="TYPE=vfat")
assert devlist == ['/dev/msdosfs/EFISYS']

# lp: #1841466
devlist = util.find_devs_with_freebsd(criteria="LABEL_FATBOOT=A_LABEL")
assert devlist == []
devlist = util.find_devs_with_freebsd(criteria=criteria)
assert devlist == expected_devlist

@pytest.mark.parametrize(
'criteria,expected_devlist', (
(None, ['/dev/ld0', '/dev/dk0', '/dev/dk1', '/dev/cd0']),
('TYPE=iso9660', ['/dev/cd0']),
('TYPE=vfat', ["/dev/ld0", "/dev/dk0", "/dev/dk1"]),
('LABEL_FATBOOT=A_LABEL', # lp: #1841466
['/dev/ld0', '/dev/dk0', '/dev/dk1', '/dev/cd0']),
)
)
@mock.patch("cloudinit.subp.subp")
def test_find_devs_with_netbsd(self, m_subp):
def test_find_devs_with_netbsd(self, m_subp, criteria, expected_devlist):
side_effect_values = [
("ld0 dk0 dk1 cd0", ""),
(
Expand Down Expand Up @@ -1070,22 +1077,7 @@ def test_find_devs_with_netbsd(self, m_subp):
),
]
m_subp.side_effect = side_effect_values
devlist = util.find_devs_with_netbsd()
assert set(devlist) == set(
["/dev/ld0", "/dev/dk0", "/dev/dk1", "/dev/cd0"]
)

m_subp.side_effect = side_effect_values
devlist = util.find_devs_with_netbsd(criteria="TYPE=iso9660")
assert devlist == ["/dev/cd0"]

m_subp.side_effect = side_effect_values
devlist = util.find_devs_with_netbsd(criteria="TYPE=vfat")
assert devlist == ["/dev/ld0", "/dev/dk0", "/dev/dk1"]

# lp: #1841466
m_subp.side_effect = side_effect_values
devlist = util.find_devs_with_netbsd(criteria="LABEL_FATBOOT=A_LABEL")
assert devlist == ['/dev/ld0', '/dev/dk0', '/dev/dk1', '/dev/cd0']
devlist = util.find_devs_with_netbsd(criteria=criteria)
assert devlist == expected_devlist

# vi: ts=4 expandtab