Skip to content

Fix 'Users and Groups' configuration documentation#530

Merged
OddBloke merged 1 commit into
canonical:masterfrom
sshedi:fix-users-groups-doc
Aug 13, 2020
Merged

Fix 'Users and Groups' configuration documentation#530
OddBloke merged 1 commit into
canonical:masterfrom
sshedi:fix-users-groups-doc

Conversation

@sshedi
Copy link
Copy Markdown
Contributor

@sshedi sshedi commented Aug 11, 2020

Few of the 'User and Groups' configurations in cloud-config have no effect on
already existing users. This was not documented earlier.

This change set adds that information to documentation.

Signed-off-by: Shreenidhi Shedi sshedi@vmware.com

@sshedi
Copy link
Copy Markdown
Contributor Author

sshedi commented Aug 11, 2020

@OddBloke - I created a new PR and removed the other one.

@mitechie
Copy link
Copy Markdown
Contributor

It looks like you've got a couple of lines that are too long that are failing the linter checks. Can you fix those up please?

Copy link
Copy Markdown
Collaborator

@OddBloke OddBloke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sshedi, I have a few comments inline.

Comment thread cloudinit/config/cc_users_groups.py Outdated
Comment thread cloudinit/config/cc_users_groups.py Outdated
Comment thread doc/examples/cloud-config-user-groups.txt Outdated
Few of the 'User and Groups' configurations in cloud-config have no effect on
already existing users. This was not documented earlier.

This change set adds that information to documentation.

Signed-off-by: Shreenidhi Shedi <sshedi@vmware.com>
Copy link
Copy Markdown
Collaborator

@OddBloke OddBloke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the back and forth!

@OddBloke OddBloke merged commit 4fb7eab into canonical:master Aug 13, 2020
@sshedi sshedi deleted the fix-users-groups-doc branch August 13, 2020 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants