tox.ini: pin correct version of httpretty in xenial{,-dev} envs#531
Merged
Conversation
The version was bumped in c724805 to support running on Python 3.7+ systems. Now that we have separate `xenial` and `xenial-dev` tox environments, we can restore the correct pinning for `xenial` without breaking `xenial-dev` on developer machines. Also drop the `mock` dependency from `xenial-shared-deps`; its removal was missed in 5f8f85b.
TheRealFalcon
approved these changes
Aug 12, 2020
Contributor
TheRealFalcon
left a comment
TheRealFalcon
left a comment
There was a problem hiding this comment.
I think you might have explained this already, but why do we need to pin to the version available in the repo vs just using a pip dependency?
Collaborator
Author
The unittests run during package build, and we can only install packages from the archive in the build environment. The packages which are installed into that environment are expressed in Lines 5 to 22 in d80d0fc |
blackboxsw
approved these changes
Aug 13, 2020
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The version was bumped in c724805 to
support running on Python 3.7+ systems. Now that we have separate
xenialandxenial-devtox environments, we can restore the correctpinning for
xenialwithout breakingxenial-devon developermachines.
Also drop the
mockdependency fromxenial-shared-deps; its removalwas missed in 5f8f85b.