Skip to content

Add Alpine Linux support.#535

Merged
raharper merged 19 commits into
canonical:masterfrom
dermotbradley:add-alpine-linux-support
Aug 19, 2020
Merged

Add Alpine Linux support.#535
raharper merged 19 commits into
canonical:masterfrom
dermotbradley:add-alpine-linux-support

Conversation

@dermotbradley
Copy link
Copy Markdown
Contributor

Add new module cc_apk_configure for creating Alpine /etc/apk/repositories file.
Modify cc_ca_certs, cc_ntp, cc_power_state_change, and cc_resolv_conf for Alpine.
Add Alpine template files for Chrony and Busybox NTP support.
Add Alpine template file for /etc/hosts.

Add new module cc_apk_configure for creating Alpine /etc/apk/repositories file.
Modify cc_ca_certs, cc_ntp, cc_power_state_change, and cc_resolv_conf for
Alpine.
Add Alpine template files for Chrony and Busybox NTP support.
Add Alpine template file for /etc/hosts.
@dermotbradley
Copy link
Copy Markdown
Contributor Author

dermotbradley commented Aug 14, 2020

Hi @OddBloke, I could do with some advice/help here with the test_handler_apk_configure.py.

Thanks to help from @raharper I fixed the test_handler.

Copy link
Copy Markdown
Collaborator

@raharper raharper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This is a really nice PR and great addition to cloud-init.

Comment thread cloudinit/config/cc_ca_certs.py Outdated
Comment thread tests/unittests/test_handler/test_handler_apk_configure.py Outdated
Comment thread cloudinit/config/cc_apk_configure.py Outdated
Comment thread cloudinit/config/cc_apk_configure.py Outdated
Comment thread cloudinit/config/cc_apk_configure.py Outdated
Comment thread cloudinit/config/cc_ntp.py Outdated
Comment thread cloudinit/config/cc_power_state_change.py Outdated
Comment thread cloudinit/config/cc_power_state_change.py Outdated
Comment thread cloudinit/config/cc_power_state_change.py Outdated
Comment thread cloudinit/config/cc_power_state_change.py Outdated
@dermotbradley dermotbradley requested a review from raharper August 17, 2020 14:43
Copy link
Copy Markdown
Collaborator

@raharper raharper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank for updating this PR. I've a few more bits of feedback on updating the unittests.

Comment thread cloudinit/config/cc_power_state_change.py Outdated
Comment thread tests/unittests/test_handler/test_handler_apk_configure.py
Comment thread tests/unittests/test_handler/test_handler_apk_configure.py Outdated
Comment thread tests/unittests/test_handler/test_handler_apk_configure.py Outdated
Comment thread tests/unittests/test_handler/test_handler_apk_configure.py Outdated
Comment thread tests/unittests/test_handler/test_handler_apk_configure.py Outdated
Comment thread tests/unittests/test_handler/test_handler_apk_configure.py Outdated
Comment thread tests/unittests/test_handler/test_handler_apk_configure.py
Comment thread tests/unittests/test_handler/test_handler_ntp.py Outdated
Comment thread cloudinit/config/cc_apk_configure.py
Comment thread cloudinit/config/cc_ntp.py
@dermotbradley dermotbradley requested a review from raharper August 19, 2020 02:35
Copy link
Copy Markdown
Collaborator

@raharper raharper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is very close; just a few more spots we can clean up.

Comment thread cloudinit/config/cc_apk_configure.py Outdated
Comment thread cloudinit/config/cc_apk_configure.py Outdated
Comment thread cloudinit/config/cc_apk_configure.py Outdated
Comment thread cloudinit/config/cc_ca_certs.py Outdated
Comment thread cloudinit/config/cc_ntp.py Outdated
Comment thread cloudinit/config/cc_power_state_change.py Outdated
Comment thread tests/unittests/test_handler/test_handler_ntp.py
Comment thread tests/unittests/test_handler/test_handler_ntp.py
Comment thread cloudinit/config/cc_ntp.py Outdated
@dermotbradley dermotbradley requested a review from raharper August 19, 2020 20:33
Comment thread cloudinit/config/cc_apk_configure.py Outdated
Copy link
Copy Markdown
Collaborator

@raharper raharper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@raharper raharper merged commit 79a8ce7 into canonical:master Aug 19, 2020
@dermotbradley dermotbradley deleted the add-alpine-linux-support branch November 18, 2020 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants