fix: rh_subscription org value#5390
Conversation
alabonne-ca
left a comment
There was a problem hiding this comment.
LGTM, thanks for delving into this ![]()
|
Looks good to me, thank you for cleaning this up! |
aciba90
left a comment
There was a problem hiding this comment.
Thanks for reporting and addressing this!
| "org": { | ||
| "type": "integer", | ||
| "description": "The organization number to use. Must be used with ``activation-key``. Should not be used with ``username`` or ``password``" | ||
| "type": "string", |
There was a problem hiding this comment.
As the value of this is ultimately going to be passed as string to subscription-manager and in order to maintain backwards compatibility, I think we should maintain both types as valid and mark integer as deprecated.
There was a problem hiding this comment.
Thank you for the feedback. I will address this in a new commit!
There was a problem hiding this comment.
@holmanb No updates. If someone can handle in a new PR, I'm welcome to it. I haven't had the time to familiarize myself with the deprecation syntax and rebase with the changes to documentation.
There was a problem hiding this comment.
@pneigel-ca Is 8532268+pneigel-ca@users.noreply.github.com your preferred email for the commit message?
There was a problem hiding this comment.
@holmanb Thanks for checking in - I didn't configure my email properly in git 😄
patrick.neigel@gmail.com can be used.
Update
orgtype fromintegertostring, updated unit test that referencesorg.Fixes GH-5382
Proposed Commit Message
Additional Context
The original issue identified schema errors for values that were determined to be appropriate using underlying tools.
Test Steps
Provide sample configuration for
rh_subscriptionusing astringfor the value oforgand it should be free of schema errors when validated, ie:cloud-init schema --systemChecklist
Merge type