typing: add check_untyped_defs#5409
Merged
Merged
Conversation
TheRealFalcon
approved these changes
Jun 20, 2024
Contributor
TheRealFalcon
left a comment
TheRealFalcon
left a comment
There was a problem hiding this comment.
One inline nit, but otherwise LGTM!
a-dubs
approved these changes
Jun 24, 2024
Contributor
a-dubs
left a comment
a-dubs
left a comment
There was a problem hiding this comment.
Changes look good. Should we create an issue referencing this for future work needed to get this enabled on all modules?
aciba90
added a commit
to aciba90/cloud-init
that referenced
this pull request
Jun 25, 2024
Add the lint to check bodies of untyped definitions[1] which is enabled by default in mypy v1.0.0[2]. Disable modules that do not pass this check with the intention to fix them in the future but not add new modules or make the lint not pass for already passing ones. Rerefences: [1] https://mypy.readthedocs.io/en/stable/config_file.html#confval-check_untyped_defs [2] pandas-dev/pandas@20e4c18
aciba90
added a commit
to aciba90/cloud-init
that referenced
this pull request
Jun 25, 2024
aciba90
force-pushed
the
check_untyped_defs
branch
from
52f0db8 to
ee3959f
Compare
Add the lint to check bodies of untyped definitions[1] which is enabled by default in mypy v1.0.0[2]. Disable modules that do not pass this check with the intention to fix them in the future but not add new modules or make the lint not pass for already passing ones. Rerefences: [1] https://mypy.readthedocs.io/en/stable/config_file.html#confval-check_untyped_defs [2] pandas-dev/pandas@20e4c18
aciba90
force-pushed
the
check_untyped_defs
branch
from
ee3959f to
e46ddc0
Compare
aciba90
added a commit
that referenced
this pull request
Jun 25, 2024
Add the lint to check bodies of untyped definitions[1] which is enabled by default in mypy v1.0.0[2]. Disable modules that do not pass this check with the intention to fix them in the future but not add new modules or make the lint not pass for already passing ones. Rerefences: [1] https://mypy.readthedocs.io/en/stable/config_file.html#confval-check_untyped_defs [2] pandas-dev/pandas@20e4c18
aciba90
added a commit
that referenced
this pull request
Jun 25, 2024
Merged
holmanb
pushed a commit
that referenced
this pull request
Jun 28, 2024
Add the lint to check bodies of untyped definitions[1] which is enabled by default in mypy v1.0.0[2]. Disable modules that do not pass this check with the intention to fix them in the future but not add new modules or make the lint not pass for already passing ones. Rerefences: [1] https://mypy.readthedocs.io/en/stable/config_file.html#confval-check_untyped_defs [2] pandas-dev/pandas@20e4c18
holmanb
pushed a commit
that referenced
this pull request
Jun 28, 2024
holmanb
pushed a commit
that referenced
this pull request
Jun 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Commit Message
Additional Context
Test Steps
Checklist
Merge type