Skip to content

Focal test updates#5476

Merged
TheRealFalcon merged 3 commits into
canonical:mainfrom
TheRealFalcon:focal-fixes
Jul 1, 2024
Merged

Focal test updates#5476
TheRealFalcon merged 3 commits into
canonical:mainfrom
TheRealFalcon:focal-fixes

Conversation

@TheRealFalcon
Copy link
Copy Markdown
Contributor

Proposed Commit Message

test: Update integration tests to pass on focal

- Update deprecation test to include focal.
- Update test using `cloud-id` appropriately

Additional Context

Test Steps

Merge type

  • Squash merge using "Proposed Commit Message"
  • Rebase and merge unique commits. Requires commit messages per-commit each referencing the pull request number (#<PR_NUM>)

Copy link
Copy Markdown
Collaborator

@blackboxsw blackboxsw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it. Agreed it makes sense to avoid the per-series deprecation-boundary based conditionals given that our lowest supported series focal is below the 22.1 deprecation_boundary of ca-certs. ssh-authorized-keys as a deprecation_version of 18.3 which is below all our stable series that get SRUs, so no need to complicate the integration test with per-series conditionals if we can select a deprecated key that happens to be derpecated everywhere. We have other integration tests that cover cases where some stable series log at INFO level and some at DEPRECATED level so we don't need that complexity/duplication of testing here as well.

@TheRealFalcon TheRealFalcon merged commit 40e2eb4 into canonical:main Jul 1, 2024
@TheRealFalcon TheRealFalcon deleted the focal-fixes branch July 1, 2024 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants