test: Fix no default user in test_status.py#5478
Merged
Merged
Conversation
blackboxsw
requested changes
Jul 2, 2024
Collaborator
blackboxsw
left a comment
blackboxsw
left a comment
There was a problem hiding this comment.
Can we move away from deprecated key ca-certs too?
| - name: something | ||
| ssh-authorized-keys: ["something"] | ||
| - default | ||
| ca-certs: |
Collaborator
There was a problem hiding this comment.
I think we also need to change ca-certs to ca_certs to avoid getting integration test failures in the following test:
FAILED tests/integration_tests/cmd/test_status.py::test_status_json_errors - assert 'Deprecated cloud-config provided: users.0.ssh-authorized-keys' in 'Deprecated cloud-config provided: ca-certs: Deprecated in version 22.3. Use ``ca_certs`` instead., use...
holmanb
pushed a commit
to holmanb/cloud-init
that referenced
this pull request
Aug 2, 2024
Also use ca_certs instead of ca-certs deprecated key
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Commit Message
Additional Context
Test Steps
Merge type