Skip to content

test: Add jsonschema guard in test_cc_ubuntu_pro.py#5479

Merged
blackboxsw merged 2 commits into
canonical:mainfrom
TheRealFalcon:guard-jsonschema
Jul 2, 2024
Merged

test: Add jsonschema guard in test_cc_ubuntu_pro.py#5479
blackboxsw merged 2 commits into
canonical:mainfrom
TheRealFalcon:guard-jsonschema

Conversation

@TheRealFalcon
Copy link
Copy Markdown
Contributor

jsonschema is still a soft dependency, so don't fail it not present.

Proposed Commit Message

test: Add jsonschema guard in test_cc_ubuntu_pro.py

jsonschema is still a soft dependency, so don't fail it not present.

Additional Context

Test Steps

Ran tests with jsonschema both installed and uninstalled.

Merge type

  • Squash merge using "Proposed Commit Message"
  • Rebase and merge unique commits. Requires commit messages per-commit each referencing the pull request number (#<PR_NUM>)

jsonschema is still a soft dependency, so don't fail it not present.
Copy link
Copy Markdown
Collaborator

@blackboxsw blackboxsw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM tested in virtenv w/out jsonschema.

@blackboxsw blackboxsw merged commit b0d6c7d into canonical:main Jul 2, 2024
holmanb pushed a commit to holmanb/cloud-init that referenced this pull request Aug 2, 2024
jsonschema is still a soft dependency, so don't fail it not present.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants