Skip to content

Add support to EC2 for identifying Vultr cloud.#628

Closed
smoser wants to merge 1 commit into
canonical:masterfrom
smoser:fix/1901458-vultr-ec2-id
Closed

Add support to EC2 for identifying Vultr cloud.#628
smoser wants to merge 1 commit into
canonical:masterfrom
smoser:fix/1901458-vultr-ec2-id

Conversation

@smoser
Copy link
Copy Markdown
Collaborator

@smoser smoser commented Oct 26, 2020

Proposed Commit Message

Add support to EC2 for identifying Vultr cloud.

Vultr.com cloud runs a ec2 compatible metadata service.
This correctly identifies that cloud so that users do not see an
EC2 strict warning.

LP: #1901458

Additional Context

As reported in bug LP: #1901458, Vultr will show the ec2 strict warning.

It seems that it would be better to have native support for vultr's metadata service documented https://www.vultr.com/metadata/#metadata .

Test Steps

Checklist:

  • My code follows the process laid out in the documentation
  • I have updated or added any unit tests accordingly
  • I have updated or added any documentation accordingly

@smoser
Add support to EC2 for identifying Vultr cloud.
90883ba 
Vultr.com cloud runs a ec2 compatible metadata service.
This correctly identifies that cloud so that users do not see an
EC2 strict warning.

LP: #1901458
@smoser smoser force-pushed the fix/1901458-vultr-ec2-id branch from b61d28f to 90883ba Compare October 26, 2020 14:30
igalic
igalic approved these changes Oct 26, 2020
View reviewed changes
Copy link
Copy Markdown
Collaborator

@igalic igalic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks rather sensible
i think I'm just surprised it's not been provided by anyone from Vultr

@smoser
Copy link
Copy Markdown
Collaborator Author

smoser commented Oct 26, 2020

this looks rather sensible
i think I'm just surprised it's not been provided by anyone from Vultr

They seem to have taken a different path to getting rid of the warning:

@eb3095
Copy link
Copy Markdown
Contributor

eb3095 commented Oct 26, 2020

Hello,

We have an active project for adding a Vultr datasource we hope to submit shortly. We are trying to move away from using the EC2 datasource.

@smoser
Copy link
Copy Markdown
Collaborator Author

smoser commented Oct 26, 2020

Hello,

We have an active project for adding a Vultr datasource we hope to submit shortly. We are trying to move away from using the EC2 datasource.

@eb3095 thanks for responding. Is we above associated with Vultr officially?

@ddymko
Copy link
Copy Markdown
Contributor

ddymko commented Oct 26, 2020

Hey @smoser

Correct, as @eb3095 mentioned we (vultr) have been working on DataSourceVultr.py and are hoping to get it wrapped up and submit PR for that soon.

If you have any questions feel free to tag myself or @eb3095 .

@smoser
Copy link
Copy Markdown
Collaborator Author

smoser commented Oct 26, 2020

@eb3095, @ddymko,

Do you want to hold off on this pull request (which would squelch the warning) in order to "do it right"?

@ddymko
Copy link
Copy Markdown
Contributor

ddymko commented Oct 26, 2020

If that wouldn't be an issue that would be great. @eb3095 any issues with this?

@eb3095
Copy link
Copy Markdown
Contributor

eb3095 commented Oct 26, 2020

Yeah that works for me. Thank you.

@smoser
Copy link
Copy Markdown
Collaborator Author

smoser commented Oct 26, 2020

Then I'll just close this.
@eb3095 , @ddymko please request my review on the PR, and feel free to ask questions.

@smoser smoser closed this Oct 26, 2020
@ddymko ddymko mentioned this pull request Mar 3, 2021
Merged
3 tasks
smoser pushed a commit that referenced this pull request Apr 13, 2021
@ddymko
Add Vultr support (#827)
0ae0b1d 
This PR adds in support so that cloud-init can run on instances 
deployed on Vultr cloud. This was originally brought up in #628.

Co-authored-by: Eric Benner <ebenner@vultr.com>
@ubuntu-server-builder ubuntu-server-builder mentioned this pull request May 12, 2023
Closed
@ani-sinha ani-sinha mentioned this pull request Jul 3, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@igalic igalic igalic approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@smoser @eb3095 @ddymko @igalic