Skip to content

Optionalize bash completion.#6441

Merged
blackboxsw merged 3 commits into
canonical:mainfrom
3405691582:bash_option
Sep 5, 2025
Merged

Optionalize bash completion.#6441
blackboxsw merged 3 commits into
canonical:mainfrom
3405691582:bash_option

Conversation

@3405691582
Copy link
Copy Markdown
Contributor

To allow for a low-dependency installation of cloud-init, optionalize the bash-completion dependency, defaulted to true. This means behaviorally nothing changes, but that the bash-completion features can be easily turned off if not desired.

Proposed Commit Message

feat: Optionalize bash completion.

To allow for a low-dependency installation of cloud-init, optionalize the
bash-completion dependency, defaulted to true. This means behaviorally
nothing changes, but that the bash-completion features can be easily
turned off if not desired.

Additional Context

n/a

Test Steps

  • Testing: with bash-completion not installed, meson build -Dbash-completion=false ... runs successfully, meson build -Dbash-completion=true ... and with -D option omitted displays error.

Merge type

  • Squash merge using "Proposed Commit Message"
  • Rebase and merge unique commits. Requires commit messages per-commit each referencing the pull request number (#<PR_NUM>)

To allow for a low-dependency installation of cloud-init, optionalize the
bash-completion dependency, defaulted to true. This means behaviorally
nothing changes, but that the bash-completion features can be easily
turned off if not desired.
Copy link
Copy Markdown
Collaborator

@blackboxsw blackboxsw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing to cloud-init. I agree with this approach and the ability to limit package dependencies where unnecessary.

Comment thread meson.build Outdated
Comment thread meson_options.txt Outdated
@blackboxsw
Copy link
Copy Markdown
Collaborator

Thanks again @3405691582 if you agree to the changes suggested above I;ll happily merge this approach.

@blackboxsw blackboxsw self-assigned this Sep 3, 2025
3405691582 and others added 2 commits September 3, 2025 18:50
Co-authored-by: Chad Smith <chad.smith@canonical.com>
Co-authored-by: Chad Smith <chad.smith@canonical.com>
@3405691582
Copy link
Copy Markdown
Contributor Author

Done. Thanks!

Copy link
Copy Markdown
Collaborator

@blackboxsw blackboxsw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@blackboxsw blackboxsw merged commit 1e9aba6 into canonical:main Sep 5, 2025
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants