Skip to content

Update wait_for_cloud_init.rst to be more consistent about systemd usage#6442

Merged
aciba90 merged 2 commits into
canonical:mainfrom
ExplGamma:patch-1
Sep 3, 2025
Merged

Update wait_for_cloud_init.rst to be more consistent about systemd usage#6442
aciba90 merged 2 commits into
canonical:mainfrom
ExplGamma:patch-1

Conversation

@ExplGamma
Copy link
Copy Markdown
Contributor

Proposed Commit Message

docs: Update wait_for_cloud_init.rst to be more consistent about systemd usage

Correcting minor documentation inconsistency.

Merge type

  • Squash merge using "Proposed Commit Message"
  • Rebase and merge unique commits. Requires commit messages per-commit each referencing the pull request number (#<PR_NUM>)

@github-actions github-actions Bot added the documentation This Pull Request changes documentation label Sep 2, 2025
@holmanb
Copy link
Copy Markdown
Member

holmanb commented Sep 2, 2025

Hi @ExplGamma thanks for the proposal. Can you please explain this change?

@aciba90
Copy link
Copy Markdown
Contributor

aciba90 commented Sep 2, 2025

Hey @ExplGamma, thanks for contributing.

As I see it I think it is more correct as it is, because cloud-init.target's meaning is precisely the end of cloud-init, which happens to be more or less now the end of cloud-final.service, but that could change in the future.

Unless I am missing something?

@ExplGamma
Copy link
Copy Markdown
Contributor Author

ExplGamma commented Sep 2, 2025

Hey Team - this is just to make the documentation more internally consistent. 46 lines later; this is what is shown in the example.

So either this line should change; or the example should be updated to be consistent with what this line was before. Happy to make that change instead if you prefer?

@holmanb @aciba90

Edit: 6 lines later; not 4

Copy link
Copy Markdown
Contributor

@aciba90 aciba90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks. I see now the discrepancy and the correct one is cloud-init.target. Thanks for noticing and fixing it!

@aciba90 aciba90 merged commit c5c6358 into canonical:main Sep 3, 2025
21 checks passed
blackboxsw pushed a commit to blackboxsw/cloud-init that referenced this pull request Sep 3, 2025
blackboxsw pushed a commit to blackboxsw/cloud-init that referenced this pull request Sep 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation This Pull Request changes documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants