fix: correct netplan renderer target#6465
Merged
Merged
Conversation
Only pass absolute path to netplan python API if an explicit target is passed to netplan.Renderer.render_network_state. That is, when called from cloud-init net-convert.
blackboxsw
reviewed
Sep 12, 2025
Collaborator
blackboxsw
left a comment
blackboxsw
left a comment
There was a problem hiding this comment.
LGTM @aciba90!. Thanks for the correction here and paying attention to the newly degraded integration tests. Minor nit about one-liner. Your call about what you think is more readable.
Comment on lines
+399
to
+402
| if target is None: | ||
| target_ = target | ||
| else: | ||
| target_ = fpnplan |
Collaborator
There was a problem hiding this comment.
Is this one-liner readable enough or is its behavior too convoluted?
Suggested change
| if target is None: | |
| target_ = target | |
| else: | |
| target_ = fpnplan | |
| target_ = None if target is None else fpnplan |
+1 either way I can see the integration tests succeeding with this PR.
blackboxsw
approved these changes
Sep 12, 2025
gauravmishragit663
added a commit
to gauravmishragit663/cloud-init
that referenced
this pull request
Sep 12, 2025
Fix Azure datasource _unpickle paths issue (canonical#6465)
blackboxsw
pushed a commit
to blackboxsw/cloud-init
that referenced
this pull request
Nov 17, 2025
Only pass absolute path to netplan python API if an explicit target is passed to netplan.Renderer.render_network_state. That is, when called from cloud-init net-convert.
blackboxsw
pushed a commit
to blackboxsw/cloud-init
that referenced
this pull request
Dec 3, 2025
Only pass absolute path to netplan python API if an explicit target is passed to netplan.Renderer.render_network_state. That is, when called from cloud-init net-convert.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Commit Message
Additional Context
https://github.com/canonical/cloud-init/actions/runs/17638202988/job/50118871293
Test Steps
Merge type