test: Convert test_registry.py from unittest to pytest#6479
Merged
Conversation
aciba90
suggested changes
Sep 22, 2025
Contributor
aciba90
left a comment
aciba90
left a comment
There was a problem hiding this comment.
The test migration looks good, only one comment about the superfluous fixture, thanks!
| class TestDictRegistry(TestCase): | ||
| class TestDictRegistry: | ||
| @pytest.fixture(autouse=True) | ||
| def reset_global_state(self): |
Contributor
There was a problem hiding this comment.
I don't immediately see the need for this fixture. I think the fixture can be removed.
Contributor
Author
There was a problem hiding this comment.
Okay i will remove it and push it again. Should I create a new branch or just update this branch?
Contributor
There was a problem hiding this comment.
Update this branch, thanks.
Contributor
Author
There was a problem hiding this comment.
Just did that., thanks
Contributor
There was a problem hiding this comment.
There are some lint errors, you can test it locally with tox -e do_format, Could you please fix them?
Contributor
Author
There was a problem hiding this comment.
I have fixed them can you check. thanks
GautamThorani
force-pushed
the
pytest-registry-migration
branch
from
a1b6428 to
5d58760
Compare
Refactored tests/unittests/test_registry.py to use pytest instead of unittest.TestCase as part of the pytest migration effort. - Removed TestCase inheritance and replaced with pytest fixtures - Converted self.assert* methods to bare assert statements - Replaced self.assertRaises with pytest.raises context manager - Removed unnessary global state reset fixture (per review feedback) - Maintained all original test functionality Related: canonical#6427
GautamThorani
force-pushed
the
pytest-registry-migration
branch
from
5d58760 to
01e796a
Compare
blackboxsw
pushed a commit
to blackboxsw/cloud-init
that referenced
this pull request
Nov 17, 2025
Refactored tests/unittests/test_registry.py to use pytest instead of unittest.TestCase as part of the pytest migration effort. - Removed TestCase inheritance and replaced with pytest fixtures - Converted self.assert* methods to bare assert statements - Replaced self.assertRaises with pytest.raises context manager - Removed unnessary global state reset fixture (per review feedback) - Maintained all original test functionality Related: canonical#6427
blackboxsw
pushed a commit
to blackboxsw/cloud-init
that referenced
this pull request
Dec 3, 2025
Refactored tests/unittests/test_registry.py to use pytest instead of unittest.TestCase as part of the pytest migration effort. - Removed TestCase inheritance and replaced with pytest fixtures - Converted self.assert* methods to bare assert statements - Replaced self.assertRaises with pytest.raises context manager - Removed unnessary global state reset fixture (per review feedback) - Maintained all original test functionality Related: canonical#6427
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactored tests/unittests/test_registry.py to use pytest instead of unittest.TestCase as part of the pytest migration effort.
Related: #6427