fix: install doc files that were previously installed pre-Meson#6501
Merged
Conversation
The Meson-based installation does not install these text files whereas the pre-Meson installation did, so reinstate them.
blackboxsw
approved these changes
Oct 6, 2025
Collaborator
blackboxsw
left a comment
blackboxsw
left a comment
There was a problem hiding this comment.
Thank you @dermotbradley for catching and fixing this. I can confirm the missing files when comparing our releases pre-meson to post-meson in Ubuntu as well.
csmith@midtown:~/src/cloud-init$ diff -urN p.doc q.doc
--- p.doc 2025-10-06 09:32:18.528023059 -0600
+++ q.doc 2025-10-06 09:32:06.938022440 -0600
@@ -55,9 +55,6 @@
/usr/share/doc/cloud-init/examples/seed/meta-data
/usr/share/doc/cloud-init/examples/seed/user-data
/usr/share/doc/cloud-init/examples/user-script.txt
-/usr/share/doc/cloud-init/status.txt
-/usr/share/doc/cloud-init/userdata.txt
-/usr/share/doc/cloud-init/var-lib-cloud.txt
/usr/share/doc/cloud-init-base
/usr/share/doc/cloud-init-base/NEWS.Debian.gz
/usr/share/doc/cloud-init-base/changelog.Debian.gz
- Also confirmed the proper formatting:
cat >meson.ini <<EOF
indent_size = 2
EOF
muon-v0.5.0-amd64-linux fmt -c meson.ini -i meson.build
- install works:
meson install -C ./builddir/ --destdir=installtest
find ./builddir/installtest/ | grep doc/cloud-init | tail -n 5
./builddir/installtest/usr/local/share/doc/cloud-init/examples/network-config-v1-nameserver.yaml
./builddir/installtest/usr/local/share/doc/cloud-init/examples/cloud-config-ansible-pull.txt
./builddir/installtest/usr/local/share/doc/cloud-init/userdata.txt
./builddir/installtest/usr/local/share/doc/cloud-init/status.txt
./builddir/installtest/usr/local/share/doc/cloud-init/var-lib-cloud.txt
blackboxsw
pushed a commit
to blackboxsw/cloud-init
that referenced
this pull request
Dec 12, 2025
…nical#6501) The Meson-based installation does not install these text files whereas the pre-Meson installation did, so reinstate them.
holmanb
pushed a commit
that referenced
this pull request
Dec 18, 2025
The Meson-based installation does not install these text files whereas the pre-Meson installation did, so reinstate them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Commit Message
Additional Context
Test Steps
Merge type