Skip to content

Fix typo in URL: landscape.canonical.com#6505

Merged
blackboxsw merged 1 commit into
canonical:mainfrom
ottok:fix-typo-in-domain
Oct 17, 2025
Merged

Fix typo in URL: landscape.canonical.com#6505
blackboxsw merged 1 commit into
canonical:mainfrom
ottok:fix-typo-in-domain

Conversation

@ottok
Copy link
Copy Markdown
Contributor

@ottok ottok commented Oct 11, 2025

  • I have signed the CLA: https://ubuntu.com/legal/contributors
  • I have included a comprehensive commit message using the guide below
  • I have kept the change small, avoiding unnecessary whitespace or non-functional changes.

Proposed Commit Message

Commit is following Conventional Commits.

Additional Context

This is a #hacktoberfest contribution.

Test Steps

$ tox -e py3
...
TOTAL                                                          32892   6345  12150   1584    78%
========================================================== 5304 passed, 8 skipped, 1 deselected, 13 xfailed, 2 xpassed, 22 warnings in 315.20s (0:05:15) ==========================================================
  py3: OK (331.93=setup[9.85]+cmd[322.09] seconds)
  congratulations :) (332.16 seconds)

Merge type

  • Rebase and merge unique commits. Requires commit messages per-commit each referencing the pull request number (#<PR_NUM>)

@github-actions github-actions Bot added the documentation This Pull Request changes documentation label Oct 11, 2025
@ottok
Copy link
Copy Markdown
Contributor Author

ottok commented Oct 11, 2025

Submitted during the VanLUG Hacktoberfest event 😄

ottok added a commit to ottok/cloud-init that referenced this pull request Oct 12, 2025
@ottok ottok force-pushed the fix-typo-in-domain branch from c9df3d9 to e991f70 Compare October 12, 2025 06:43
@blackboxsw
Copy link
Copy Markdown
Collaborator

Submitted during the VanLUG Hacktoberfest event 😄

Woo hoo. Thanks @ottok. If you get a chance to sign the CLA https://canonical.com/legal/contributors it'd be wonderful.

We'll get this merged.

@ottok
Copy link
Copy Markdown
Contributor Author

ottok commented Oct 13, 2025

I did sign the CLA already some time ago when I fixed autopkgtests for the command-not-found utility in https://salsa.debian.org/jak/command-not-found/-/merge_requests/8#note_516504

@blackboxsw
Copy link
Copy Markdown
Collaborator

blackboxsw commented Oct 16, 2025

I did sign the CLA already some time ago when I fixed autopkgtests for the command-not-found utility in https://salsa.debian.org/jak/command-not-found/-/merge_requests/8#note_516504

I approve this review, but our current instance of CLA signing doesn't recognize either your current github username ottok or your current email associated with your commit. Do you know if the CLA signing you performed used a different github username or email address? Those are the keys our CLA workflow depend on.

~$ curl https://cla.canonical.com/cla/check?github_usernames=ottok
{"emails":{},"github_usernames":{"ottok":false},"launchpad_usernames":{}}

~$ curl https://cla.canonical.com/cla/check?emails=otto@kekalainen.net
{"emails":{"otto@kekalainen.net":false},"github_usernames":{},"launchpad_usernames":{}}csmith@midtown:~/src/cloud-init$ 
~/src/cloud-init$ curl https://cla.canonical.com/cla/check?github_usernames=blackboxsw
{"emails":{},"github_usernames":{"blackboxsw":true},"launchpad_usernames":{}}

Copy link
Copy Markdown
Collaborator

@blackboxsw blackboxsw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to sort why our CLA is rejecting ottok

@ottok
Copy link
Copy Markdown
Contributor Author

ottok commented Oct 16, 2025

I signed the CLA again with both GitHub and Launhpad logins active:

image

@ottok ottok force-pushed the fix-typo-in-domain branch from e991f70 to 8d6adad Compare October 16, 2025 23:08
@blackboxsw
Copy link
Copy Markdown
Collaborator

Woo hoo CLA is happy! Thanks @ottok

@blackboxsw blackboxsw merged commit eb43d8e into canonical:main Oct 17, 2025
21 checks passed
@ottok
Copy link
Copy Markdown
Contributor Author

ottok commented Oct 17, 2025

Thanks for merging!

You forgot to add the hacktoberfest-approved label:

image

@ottok ottok mentioned this pull request Oct 21, 2025
4 tasks
@ottok
Copy link
Copy Markdown
Contributor Author

ottok commented Oct 21, 2025

Please add the label hacktoberfest-accepted to this Pull Request. Canonical/cloud-init is a participating organization in https://hacktoberfest.com/ and an implied promise to use these labels that Hacktoberfest organizers uses for tracking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation This Pull Request changes documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants