test(distros): Convert test_sysconfig.py from unittest to pytest#6510
Merged
blackboxsw merged 3 commits intoOct 17, 2025
Conversation
csemanish12
changed the title
blackboxsw
requested changes
Oct 16, 2025
Collaborator
blackboxsw
left a comment
blackboxsw
left a comment
There was a problem hiding this comment.
Thank you @csemanish12 for the contributions to cloud-init project health!
One minor suggestion as I don't think we need to be concerned with python 2.6 anymore.
| self.assertTrue( | ||
| regexp.search(text), | ||
| msg="%s must match %s!" % (text, regexp.pattern), | ||
| assert regexp.search(text), "%s must match %s!" % ( |
Collaborator
There was a problem hiding this comment.
I actually think we can drop this whole method assertRegMatches now as it's unused.
Contributor
Author
There was a problem hiding this comment.
agreed. the method is not used anymore. i have removed it.
Refactored tests/unittests/distros/test_sysconfig.py to use pytest instead of unittest.TestCase as part of the pytest migration effort. - Removed TestCase inheritance - Converted self.assert* methods to bare assert statements - Maintained all original test functionality Related: canonical#6427
csemanish12
force-pushed
the
pytest-sysconfig-migration
branch
from
33abb8c to
4d44b85
Compare
blackboxsw
pushed a commit
to blackboxsw/cloud-init
that referenced
this pull request
Dec 12, 2025
…onical#6510) Refactored tests/unittests/distros/test_sysconfig.py to use pytest instead of unittest.TestCase as part of the pytest migration effort. - Removed TestCase inheritance and unused py 2.6 method - Converted self.assert* methods to bare assert statements - Maintained all original test functionality Related: canonical#6427
holmanb
pushed a commit
that referenced
this pull request
Dec 18, 2025
Refactored tests/unittests/distros/test_sysconfig.py to use pytest instead of unittest.TestCase as part of the pytest migration effort. - Removed TestCase inheritance and unused py 2.6 method - Converted self.assert* methods to bare assert statements - Maintained all original test functionality Related: #6427
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactored tests/unittests/distros/test_sysconfig.py to use pytest instead of unittest.TestCase as part of the pytest migration effort.
Related: #6427