Skip to content

test(distros): Convert test_hostname.py from unittest to pytest #6511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
blackboxsw merged 1 commit into from
Oct 16, 2025
Merged

test(distros): Convert test_hostname.py from unittest to pytest #6511

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 7 additions & 10 deletions tests/unittests/distros/test_hostname.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,4 @@
# This file is part of cloud-init. See LICENSE file for license information.

import unittest

from cloudinit.distros.parsers import hostname

BASE_HOSTNAME = """
Expand All @@ -13,27 +10,27 @@
BASE_HOSTNAME = BASE_HOSTNAME.strip()


class TestHostnameHelper(unittest.TestCase):
class TestHostnameHelper:
def test_parse_same(self):
hn = hostname.HostnameConf(BASE_HOSTNAME)
self.assertEqual(str(hn).strip(), BASE_HOSTNAME)
self.assertEqual(hn.hostname, "blahblah")
assert str(hn).strip() == BASE_HOSTNAME
assert hn.hostname == "blahblah"

def test_no_adjust_hostname(self):
hn = hostname.HostnameConf(BASE_HOSTNAME)
prev_name = hn.hostname
hn.set_hostname("")
self.assertEqual(hn.hostname, prev_name)
assert hn.hostname == prev_name

def test_adjust_hostname(self):
hn = hostname.HostnameConf(BASE_HOSTNAME)
prev_name = hn.hostname
self.assertEqual(prev_name, "blahblah")
assert prev_name == "blahblah"
hn.set_hostname("bbbbd")
self.assertEqual(hn.hostname, "bbbbd")
assert hn.hostname == "bbbbd"
expected_out = """
# My super-duper-hostname

bbbbd
"""
self.assertEqual(str(hn).strip(), expected_out.strip())
assert str(hn).strip() == expected_out.strip()