test(sources): Convert test_common.py from unittest to pytest#6512
Merged
Conversation
Refactored tests/unittests/sources/test_common.py to use pytest instead of unittest.TestCase as part of the pytest migration effort. - Removed TestCase inheritance from both test classes - Renamed ExpectedDataSources to TestExpectedDataSources for pytest discovery - Converted self.assertEqual() methods to bare assert statements - Converted self.assertTrue() to assert statement - Converted self.assertNotEqual() to assert statement - Converted self.assertIsNotNone() to assert statement - Removed unused test_helpers import - Maintained all original test functionality Related: canonical#6427
blackboxsw
approved these changes
Oct 16, 2025
Collaborator
blackboxsw
left a comment
blackboxsw
left a comment
There was a problem hiding this comment.
Thank you much for this @Pneha1234. Let's convert all tests we can from test_helpers.TestCase -> pytest :). Thank you thank you!
blackboxsw
pushed a commit
to blackboxsw/cloud-init
that referenced
this pull request
Dec 12, 2025
…cal#6512) Refactored tests/unittests/sources/test_common.py to use pytest instead of unittest.TestCase as part of the pytest migration effort. - Removed TestCase inheritance from both test classes - Renamed ExpectedDataSources to TestExpectedDataSources for pytest discovery - Converted self.assertEqual() methods to bare assert statements - Converted self.assertTrue() to assert statement - Converted self.assertNotEqual() to assert statement - Converted self.assertIsNotNone() to assert statement - Removed unused test_helpers import - Maintained all original test functionality Related: canonical#6427
holmanb
pushed a commit
that referenced
this pull request
Dec 18, 2025
Refactored tests/unittests/sources/test_common.py to use pytest instead of unittest.TestCase as part of the pytest migration effort. - Removed TestCase inheritance from both test classes - Renamed ExpectedDataSources to TestExpectedDataSources for pytest discovery - Converted self.assertEqual() methods to bare assert statements - Converted self.assertTrue() to assert statement - Converted self.assertNotEqual() to assert statement - Converted self.assertIsNotNone() to assert statement - Removed unused test_helpers import - Maintained all original test functionality Related: #6427
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactored tests/unittests/sources/test_common.py to use pytest instead of unittest.TestCase as part of the pytest migration effort.
Related: #6427