test(config): Convert test_cc_spacewalk.py from unittest to pytest#6515
Merged
blackboxsw merged 1 commit intoOct 21, 2025
Merged
Conversation
blackboxsw
requested changes
Oct 17, 2025
Collaborator
blackboxsw
left a comment
blackboxsw
left a comment
There was a problem hiding this comment.
Thank you for your additional contributions. Just a minor nit since we know exactly what we should be returning as a boolean.
| def test_not_is_registered(self, mock_subp): | ||
| mock_subp.side_effect = subp.ProcessExecutionError(exit_code=1) | ||
| self.assertFalse(cc_spacewalk.is_registered()) | ||
| assert not cc_spacewalk.is_registered() |
Collaborator
There was a problem hiding this comment.
Thank you for this. Minor preference: Let's be a bit more strict about this return type of is_registered avoid truthy behavior and just strictly assert that we returned False. I don't want this test to pass if we start returning an empty dict or string in the future because we have changed the API.
Suggested change
| assert not cc_spacewalk.is_registered() | |
| assert cc_spacewalk.is_registered() is False |
Same comment below please.
| def test_is_registered(self, mock_subp): | ||
| mock_subp.side_effect = None | ||
| self.assertTrue(cc_spacewalk.is_registered()) | ||
| assert cc_spacewalk.is_registered() |
Collaborator
There was a problem hiding this comment.
Suggested change
| assert cc_spacewalk.is_registered() | |
| assert cc_spacewalk.is_registered() is True |
Pneha1234
force-pushed
the
pytest-convert-test-spacewalk
branch
from
ad60898 to
8485586
Compare
Contributor
Author
|
@blackboxsw Updated! Changed to use strict identity checks (is True / is False. Thanks for catching that! |
Pneha1234
force-pushed
the
pytest-convert-test-spacewalk
branch
from
8485586 to
f426d47
Compare
Refactored tests/unittests/config/test_cc_spacewalk.py to use pytest instead of unittest.TestCase as part of the pytest migration effort. - Removed TestCase inheritance - Removed unused helpers import - Converted self.assertFalse() to strict boolean check (is False) - Converted self.assertTrue() to strict boolean check (is True) - Maintained all original test functionality Related: canonical#6427
Pneha1234
force-pushed
the
pytest-convert-test-spacewalk
branch
from
f426d47 to
579b8c9
Compare
blackboxsw
approved these changes
Oct 21, 2025
Collaborator
blackboxsw
left a comment
blackboxsw
left a comment
There was a problem hiding this comment.
Looking great! Thanks again.
blackboxsw
pushed a commit
to blackboxsw/cloud-init
that referenced
this pull request
Dec 12, 2025
…anonical#6515) Refactored tests/unittests/config/test_cc_spacewalk.py to use pytest instead of unittest.TestCase as part of the pytest migration effort. - Removed TestCase inheritance - Removed unused helpers import - Converted self.assertFalse() to strict boolean check (is False) - Converted self.assertTrue() to strict boolean check (is True) - Maintained all original test functionality Related: canonical#6427
holmanb
pushed a commit
that referenced
this pull request
Dec 18, 2025
…6515) Refactored tests/unittests/config/test_cc_spacewalk.py to use pytest instead of unittest.TestCase as part of the pytest migration effort. - Removed TestCase inheritance - Removed unused helpers import - Converted self.assertFalse() to strict boolean check (is False) - Converted self.assertTrue() to strict boolean check (is True) - Maintained all original test functionality Related: #6427
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactored tests/unittests/config/test_cc_spacewalk.py to use pytest instead of unittest.TestCase as part of the pytest migration effort.
Related: #6427