test(distros): Convert test_ifconfig.py from unittest to pytest#6517
Merged
blackboxsw merged 2 commits intoOct 21, 2025
Conversation
Refactored tests/unittests/distros/test_ifconfig.py to use pytest instead of unittest.TestCase as part of the pytest migration effort. - Removed TestCase inheritance - Refactored tests to use pytest fixtures instead of unittest setUp methods - updated tests to receive fixtures as function arguments - Maintained all original test functionality Related: canonical#6427
blackboxsw
requested changes
Oct 21, 2025
Collaborator
blackboxsw
left a comment
blackboxsw
left a comment
There was a problem hiding this comment.
Thank you @csemanish12. A couple of minor nits and let's land this.
| def test_parse_freebsd(self): | ||
|
|
||
| @pytest.fixture | ||
| def ifs_text_freebsd_cidr(): |
Collaborator
There was a problem hiding this comment.
Let's please drop the text -> txt to keep things consistent for all fixture names.
| def test_is_physical(self, ifs_txt_openbsd): | ||
| """assert enc0 is not physical""" | ||
| ifs = Ifconfig().parse(self.ifs_txt) | ||
| ifs = Ifconfig().parse(ifs_txt_openbsd) |
Collaborator
There was a problem hiding this comment.
I realize it's not part of this PR. But, while we are here, can we please correct this docstring above?
"""assert is not physical""" Changed to """assert vio0 is physical"""
Contributor
Author
There was a problem hiding this comment.
Sure. I have updated the PR.
- removed text "txt" from fixture names - fixed doc string for test_is_physical test Related canonical#6427
blackboxsw
approved these changes
Oct 21, 2025
Collaborator
blackboxsw
left a comment
blackboxsw
left a comment
There was a problem hiding this comment.
Thank you for the updates.
blackboxsw
pushed a commit
to blackboxsw/cloud-init
that referenced
this pull request
Dec 12, 2025
…nical#6517) Refactored tests/unittests/distros/test_ifconfig.py to use pytest instead of unittest.TestCase as part of the pytest migration effort. - Removed TestCase inheritance - Refactored tests to use pytest fixtures instead of unittest setUp methods - updated tests to receive fixtures as function arguments - Maintained all original test functionality Related: canonical#6427
holmanb
pushed a commit
that referenced
this pull request
Dec 18, 2025
Refactored tests/unittests/distros/test_ifconfig.py to use pytest instead of unittest.TestCase as part of the pytest migration effort. - Removed TestCase inheritance - Refactored tests to use pytest fixtures instead of unittest setUp methods - updated tests to receive fixtures as function arguments - Maintained all original test functionality Related: #6427
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactored tests/unittests/distros/test_ifconfig.py to use pytest instead of unittest.TestCase as part of the pytest migration effort.
Related: #6427