test(distros): Convert test_user_data_normalize.py from unittest to pytest#6518
Merged
blackboxsw merged 3 commits intoOct 22, 2025
Merged
Conversation
Refactored tests/unittests/distros/test_user_data_normalize.py to use pytest instead of unittest.TestCase as part of the pytest migration effort. - Removed unittest.TestCase inheritance and `setUp` method - Added pytest.mark.parametrize for repetitive user simple dict tests - Replaced self.assert* calls with simple assert statements - Maintained all original test functionality Related: canonical#6427
- Replaced `assert True == value` with `assert value` - fixed incorrect assert "zetta", users with assert "zetta" in users
blackboxsw
requested changes
Oct 21, 2025
Collaborator
blackboxsw
left a comment
blackboxsw
left a comment
There was a problem hiding this comment.
Thank you for the addtiional contribution. @csemanish12, a couple of minor nits and let's merge this.
Comment on lines
+196
to
+197
| assert users["bob"]["blah"] | ||
| assert users["bob"]["default"] |
Collaborator
There was a problem hiding this comment.
Let's be strict about boolean assertions to avoid passing on unexpected truthy values.
Suggested change
| assert users["bob"]["blah"] | |
| assert users["bob"]["default"] | |
| assert users["bob"]["blah"] is True | |
| assert users["bob"]["default"] is True |
| == users["bob"]["groups"] | ||
| ) | ||
| self.assertEqual(True, users["bob"]["default"]) | ||
| assert users["bob"]["default"] |
Collaborator
There was a problem hiding this comment.
Suggested change
| assert users["bob"]["default"] | |
| assert users["bob"]["default"] is True |
blackboxsw
approved these changes
Oct 22, 2025
Collaborator
blackboxsw
left a comment
blackboxsw
left a comment
There was a problem hiding this comment.
Looks good to me. Good work. Thanks again.
blackboxsw
pushed a commit
to blackboxsw/cloud-init
that referenced
this pull request
Dec 12, 2025
…ytest (canonical#6518) Refactored tests/unittests/distros/test_user_data_normalize.py to use pytest instead of unittest.TestCase as part of the pytest migration effort. - Removed unittest.TestCase inheritance and `setUp` method - Added pytest.mark.parametrize for repetitive user simple dict tests - Replaced self.assert* calls with simple assert statements - Maintained all original test functionality Related: canonical#6427 * Fix assertions for pytest style - Replaced `assert True == value` with `assert value` - fixed incorrect assert "zetta", users with assert "zetta" in users * test: Be strict about boolean assertions to avoid passing unexpected truthy values
holmanb
pushed a commit
that referenced
this pull request
Dec 18, 2025
…ytest (#6518) Refactored tests/unittests/distros/test_user_data_normalize.py to use pytest instead of unittest.TestCase as part of the pytest migration effort. - Removed unittest.TestCase inheritance and `setUp` method - Added pytest.mark.parametrize for repetitive user simple dict tests - Replaced self.assert* calls with simple assert statements - Maintained all original test functionality Related: #6427 * Fix assertions for pytest style - Replaced `assert True == value` with `assert value` - fixed incorrect assert "zetta", users with assert "zetta" in users * test: Be strict about boolean assertions to avoid passing unexpected truthy values
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactored tests/unittests/distros/test_user_data_normalize.py to use pytest instead of unittest.TestCase as part of the pytest migration effort.
setUpmethodRelated: #6427