test (config): Convert test_apt_conf_v1.py from unittest to pytest#6520
Merged
blackboxsw merged 3 commits intoOct 22, 2025
Merged
Conversation
Refactored tests/unittests/config/test_apt_conf_v1.py to use pytest instead of unittest.TestCase as part of the pytest migration effort. - Removed unittest.TestCase inheritance - Converted setUp() to pytest fixture for temporary files - Parameterized proxy-related tests for cleaner duplication removal - Replaced unittest assertions with plain pytest `assert` statements - Replaced `_search_apt_config` as standalone helper function - Maintained all original test functionality Related: canonical#6427
…_variants to address parameterization
csemanish12
changed the title
csemanish12
changed the title
blackboxsw
requested changes
Oct 21, 2025
Collaborator
blackboxsw
left a comment
blackboxsw
left a comment
There was a problem hiding this comment.
Looks great. Minor spelling nits throughout test_apt_conf_v1.py as we recently had a PR fixing spelling mistakes in comments/tests etc.
|
|
||
| def test_proxy_replaced(self, p_c_files): | ||
| pfile, cfile = p_c_files | ||
| util.write_file(cfile, "content doesnt matter") |
Collaborator
There was a problem hiding this comment.
minor spelling nit.
doesn't
|
|
||
| def test_proxy_deleted(self, p_c_files): | ||
| pfile, cfile = p_c_files | ||
| util.write_file(cfile, "content doesnt matter") |
Collaborator
There was a problem hiding this comment.
minor spelling nit while we are here.
doesn't
blackboxsw
pushed a commit
to blackboxsw/cloud-init
that referenced
this pull request
Dec 12, 2025
…anonical#6520) Refactored tests/unittests/config/test_apt_conf_v1.py to use pytest instead of unittest.TestCase as part of the pytest migration effort. - Removed unittest.TestCase inheritance - Converted setUp() to pytest fixture for temporary files - Parameterized proxy-related tests for cleaner duplication removal - Replaced unittest assertions with plain pytest `assert` statements - Replaced `_search_apt_config` as standalone helper function - Maintained all original test functionality Related: canonical#6427
holmanb
pushed a commit
that referenced
this pull request
Dec 18, 2025
…6520) Refactored tests/unittests/config/test_apt_conf_v1.py to use pytest instead of unittest.TestCase as part of the pytest migration effort. - Removed unittest.TestCase inheritance - Converted setUp() to pytest fixture for temporary files - Parameterized proxy-related tests for cleaner duplication removal - Replaced unittest assertions with plain pytest `assert` statements - Replaced `_search_apt_config` as standalone helper function - Maintained all original test functionality Related: #6427
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactored tests/unittests/config/test_apt_conf_v1.py to use pytest instead of unittest.TestCase as part of the pytest migration effort.
assertstatements_search_apt_configas standalone helper functionRelated: #6427