fix(azure): catch import error as reportable#6714
Conversation
cjp256
left a comment
There was a problem hiding this comment.
It would be great to capture the cloud-init log for the failure in your message to demonstrate the testing was done successfully.
Can you add a test case in:
- test_errors.py for this new class
- test_azure.py to demonstrate this. maybe look to test_query_vm_id_system_uuid_failure for inspiration
Thanks Cade!!
Thanks for the review @cjp256! Added in tests in those two files respectively. Also, I added the output message from the VM to the commit message above. I'd be happy to make any additional changes as needed. |
|
This should be ready for review; the SSH key error that is failing the pipeline seems to be occurring in Main as well. It should not be a result of this change. |
|
@cadejacobson This doesn't merge cleanly. Please rebase on main branch. |
|
@holmanb I have merged in the most recent main and re-pushed. If it specifically requires a rebase, I would be happy to do that as well. |
|
That should suffice, thanks! |
holmanb
left a comment
There was a problem hiding this comment.
This looks good to me. Thanks!
Adds the ReportableErrorImportError class to catch a known issue with unhandled exceptions when importing crypt and passlib, but both are missing. Fixes canonicalGH-6770
Proposed Commit Message
Test Steps
python3-passlibuninstalledMerge type
Resolves #6770
cc: @cjp256 @peytonr18