Network config generation exception#709
Merged
OddBloke merged 5 commits intoDec 16, 2020
Merged
Conversation
Contributor
|
Can you add a unit test to cover the case where if ipaddress isn't there, the network config for the interface would not be generated? |
OddBloke
approved these changes
Dec 16, 2020
Collaborator
OddBloke
left a comment
There was a problem hiding this comment.
This looks good to me, thanks!
Contributor
Author
|
Thanks for the review and approval, @OddBloke! |
This was referenced May 12, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Commit Message
Prevent network interfaces without IP addresses from being added to the generated network configuration.
Additional Context
There are situations where a network interface might not have any associated IP addresses with it (this is by-design). In this case, the network configuration that is generated would currently still include these network interfaces. This could cause issues and delays in provisioning, for example if
systemd-networkd-wait-onlineis running it would be waiting until timeout because any interface without an IP address would not ever come online.This PR adds a check to make sure that we are only generating network configuration for devices with IP addresses.
Test Steps
Checklist: